gofix/portal-tunnel-rs
Watch
1
0
Fork
You've already forked portal-tunnel-rs
 0
Code Issues Pull requests Projects Releases 22 Packages 1 Wiki Activity Actions

ci(release): read the registry endpoint from the runner environment #111

Merged
ada merged 1 commit from ci/registry-from-runner-env into master 2026-10-09 03:07:20 +00:00
Conversation 0 Commits 1 Files changed 2 +13 -2
ada commented 2026-10-09 03:02:57 +00:00
Collaborator

Problem

.forgejo/workflows/container-image.yml hard-codes a deployment-specific registry hostname, which is internal topology that does not belong in the repository.

Change

  • The workflow reads the push endpoint from the runner environment variable CONTAINER_REGISTRY and fails closed when it is unset.
  • docs/RELEASE.md notes the requirement.

Validation

  • The runner now provides CONTAINER_REGISTRY.
  • The workflow only runs on tag pushes, so it is proven by the next dev tag build: the image must publish and pull by digest.

Risk

If the runner variable were missing, tag builds would fail with an explicit error. No published image changes.

## Problem `.forgejo/workflows/container-image.yml` hard-codes a deployment-specific registry hostname, which is internal topology that does not belong in the repository. ## Change - The workflow reads the push endpoint from the runner environment variable `CONTAINER_REGISTRY` and fails closed when it is unset. - `docs/RELEASE.md` notes the requirement. ## Validation - The runner now provides `CONTAINER_REGISTRY`. - The workflow only runs on tag pushes, so it is proven by the next dev tag build: the image must publish and pull by digest. ## Risk If the runner variable were missing, tag builds would fail with an explicit error. No published image changes.
ci(release): read the registry endpoint from the runner environment
All checks were successful
Rust CI / Format, lint, and test (pull_request) Successful in 3m48s
Details
Rust CI / Build and start linux/arm64 image (no push) (pull_request) Successful in 10s
Details
9c5bf8f812 
The tag-publishing workflow hard-coded a deployment-specific registry hostname. Read it from the runner-provided CONTAINER_REGISTRY instead and fail closed when it is unset, keeping the repository host-neutral.
ada merged commit 4396e29b0e into master 2026-10-09 03:07:20 +00:00
ada deleted branch ci/registry-from-runner-env 2026-10-09 03:07:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gofix/portal-tunnel-rs!111
No description provided.